Re: [PATCH 11/31] ASoC: pcm6240: Use auto-cleanup for firmware loading
Herve Codina <[email protected]> Wed, 5 Aug 2026 18:47:05 +0200
| Newsgroups | org.kernel.vger.linux-sound |
|---|---|
| Organization | Bootlin |
| Message-ID | <[email protected]> |
Hi Takashi, On Wed, 5 Aug 2026 15:52:12 +0200 Takashi Iwai <[email protected]> wrote: > Simplify the code to manage the firmware loading with __free(firmware) > auto-cleanup. > > Since the firmware release is cleaned up automatically, we can convert > the mutex call with guard() gracefully, too. > > Only the code refactoring, no functional changes. > > Cc: Herve Codina <[email protected]> > Signed-off-by: Takashi Iwai <[email protected]> > --- > sound/soc/codecs/pcm6240.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > Hum, I am in Cc but I think it is the wrong commit. I would expect to be in Cc of modification related to the peb2466 codec. Anyway, for this one, modification looks good to me. Reviewed-by: Herve Codina <[email protected]> Also I will retrieve the peb2466 patch (patch 12/31) directly from lore and reply. Best regards, Hervé