Re: [PATCH 23/31] ASoC: wm2000: Use auto-cleanup for firmware loading

Mark Brown <[email protected]> Thu, 6 Aug 2026 00:16:10 +0100

Newsgroups	org.kernel.vger.linux-sound
Message-ID	<[email protected]>

On Wed, Aug 05, 2026 at 03:52:24PM +0200, Takashi Iwai wrote:
> Simplify the code to manage the firmware loading with __free(firmware)
> auto-cleanup.

>  	for (i = 0; i < WM2000_NUM_SUPPLIES; i++)
> @@ -876,6 +875,7 @@ static int wm2000_i2c_probe(struct i2c_client *i2c)
>  			filename = pdata->download_file;
>  	}
>  
> +	const struct firmware *fw __free(firmware) = NULL;
>  	ret = request_firmware(&fw, filename, &i2c->dev);
>  	if (ret != 0) {
>  		dev_err(&i2c->dev, "Failed to acquire ANC data: %d\n", ret);

Same goto issue here.

signature.asc (application/pgp-signature, 488 B)