Re: [PATCH 13/31] ASoC: rt1320-sdw: Use auto-cleanup for firmware loading

Mark Brown <[email protected]> Thu, 6 Aug 2026 12:52:48 +0100

Newsgroups	org.kernel.vger.linux-sound
Message-ID	<[email protected]>

On Thu, Aug 06, 2026 at 09:37:14AM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > There's a goto further up that jumps over this which clang warns about,
> > this will break the build.  Landmines like that are why cleanup.h warns
> > about mixing it with goto.

> That's an issue because I moved the declaration of the variable fw;
> if it's left at the beginning of the function as it was, it should
> work fine, like the patch below.  The same applied to the error for
> wm2000.

Yes, it's fine when the declaration is at the beginning IIRC (though not
ideal stylistically) - the warning is generated when a goto jumps over a
declaration.

signature.asc (application/pgp-signature, 488 B)