Re: [PATCH 13/31] ASoC: rt1320-sdw: Use auto-cleanup for firmware loading

On Thu, 06 Aug 2026 13:52:48 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 06, 2026 at 09:37:14AM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > There's a goto further up that jumps over this which clang warns about,
> > > this will break the build.  Landmines like that are why cleanup.h warns
> > > about mixing it with goto.
> 
> > That's an issue because I moved the declaration of the variable fw;
> > if it's left at the beginning of the function as it was, it should
> > work fine, like the patch below.  The same applied to the error for
> > wm2000.
> 
> Yes, it's fine when the declaration is at the beginning IIRC (though not
> ideal stylistically) - the warning is generated when a goto jumps over a
> declaration.

OK, I'm going to submit v2 series.


thanks,

Takashi