Re: [PATCH] ASoC: xilinx: formatter_pcm: use devm_clk_get_enabled and simplify probe

Mark Brown <[email protected]>
Newsgroups org.kernel.vger.linux-sound,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Thu, Aug 06, 2026 at 04:38:12PM -0700, Rosen Penev wrote:
> Use devm_clk_get_enabled() to let the clock be enabled automatically
> and cleaned up on unbind, dropping the manual clk_prepare_enable() and
> clk_disable_unprepare() calls in probe and remove.
> 
> Simplify the probe error paths by returning directly instead of
> jumping to clk_err, and use devm_snd_soc_register_component() return
> value directly.
> 
> Assisted-by: opencode:deepseek-v4-flash-free
> ---
>  sound/soc/xilinx/xlnx_formatter_pcm.c | 47 ++++++++-------------------

You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.
signature.asc (application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmp1HDwACgkQJNaLcl1U
h9AgcAf/XKL7xUSbmRRfV1Xf1pAt9hc7vV91sDkz/pszgYtTKuHK1UxO5mctw/n2
PHxst+59W3feDmAeukN8XpGW2MjtLqDKkVlLV28fSOXyWDOV7ULCUvwfKBSsQRjY
SIry+jGcn0AGaUR/FG3s2EDma4aWund8XD/qKWSmB4ZKlBD8CFy0xSGnbT4DYSMe
pyZscTpdQDZ6F6Njt13aMG37sUiBzOOCEggfkaaKfVrGhmqkdP4MBStmxBqTbO2r
gBqMtvBhrxhOtnXme/aGaWP22M1pzuLeQVNSovc+4SN5QBP3FZN13oJVYD8YzewT
skPIY8fsUS+mDy2PlnjEXx1dSs9ZuA==
=1T0e
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.