Re: [PATCH 4/4] ASoC: sti-sas: sort the register default table

On 8/5/26 14:28, Peter Ujfalusi wrote:
> reg_defaults must be sorted by ascending register address, as
> regcache_lookup_reg() locates entries in it with bsearch().  See commit
> fd80df352ba1 ("regcache: Add support for sorting defaults arrays").
> 
> STIH407_AUDIO_DAC_CTRL (0xa8) is listed before
> STIH407_AUDIO_GLUE_CTRL (0xa4), which makes the latter unreachable.
> regcache_reg_needs_sync() then cannot compare it against its default and
> reports that a sync is needed, so it is written to the device on every
> regcache_sync() even when it was never touched.
> 
> Sort the table by register address.
> 
> Fixes: 165a57a3df02 ("ASoC: sti-sas: clean legacy in sti-sas")
> Cc: [email protected]
> Signed-off-by: Peter Ujfalusi <[email protected]>
> ---
>  sound/soc/codecs/sti-sas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/sti-sas.c b/sound/soc/codecs/sti-sas.c
> index 4ab15be69f3a..b7eaf4795d8b 100644
> --- a/sound/soc/codecs/sti-sas.c
> +++ b/sound/soc/codecs/sti-sas.c
> @@ -44,8 +44,8 @@ enum {
>  };
>  
>  static const struct reg_default stih407_sas_reg_defaults[] = {
> -	{ STIH407_AUDIO_DAC_CTRL, 0x000000000 },
>  	{ STIH407_AUDIO_GLUE_CTRL, 0x00000040 },
> +	{ STIH407_AUDIO_DAC_CTRL, 0x000000000 },
>  };
>  
>  struct sti_dac_audio {


Hi Peter

Reviewed-by: Patrice Chotard <[email protected]>

Thanks
Patrice