Re: [PATCH] ALSA: seq: Drop the dead struct snd_seq_event_bounce

Takashi Iwai <[email protected]>
Newsgroups org.kernel.vger.linux-sound,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Wed, 12 Aug 2026 16:15:06 +0200,
HyeongJun An wrote:
> 
> The struct describes a bounce payload of an error code followed by the
> original event and its external data.  No kernel has ever sent that.
> Before commit efc86691e4d8 ("ALSA: seq: Fix kernel heap address leak in
> bounce_error_event()") the kernel emitted no SNDRV_SEQ_EVENT_BOUNCE at
> all, and since then it sends the event record alone.
> 
> Nothing has ever read it either.  Its only accessor,
> snd_seq_event_bounce_ext_data(), has had no caller for the whole git
> history, and it did not even compile until commit c7e0b5bf9fff ("[ALSA]
> Remove xxx_t typedefs: Sequencer") incidentally repaired the type name
> it referred to, three years after the git import.  Drop the accessor
> along with the struct.
> 
> This removes a definition from a UAPI header.  Since no kernel ever
> produced the layout, nothing can have parsed it, but a program that
> merely names the type will need to stop.
> 
> Suggested-by: Takashi Iwai <[email protected]>
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: HyeongJun An <[email protected]>

Applied to for-next branch now.  Thanks.


Takashi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.