Re: [PATCH] ASoC: tas2781: Add delay before block checksum retry to prevent deadlock
Mark Brown <[email protected]>
| Newsgroups | org.kernel.vger.linux-sound,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Aug 15, 2026 at 02:19:26AM +0800, 李则良 wrote:
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
> @@ -1765,9 +1765,16 @@ static int tasdev_block_chksum(struct
> tasdevice_priv *tas_priv,
> ret = -EAGAIN;
> block->nr_retry--;
>
> - if (block->nr_retry <= 0)
> + if (block->nr_retry <= 0) {
> set_err_prg_cfg(block->type,
> &tas_priv->tasdevice[chn]);
> +
> + } else {
> + /* Give the chip and I2C bus time to stabilize before
> + * next re-transmission attempt.
> + */
> + usleep_range(2000, 2500);
> + }
> } else
> tas_priv->tasdevice[chn].err_code &= ~ERROR_PRAM_CRCCHK;
Your mail software has mangled this patch so it's unusable - at least
all the tabs have been replaced by spaces. You might want to look at b4
to send the patches, especially it's web submission endpoint which
avoids having to configure mail:
https://b4.docs.kernel.org/en/latest/contributor/overview.html
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmp/Ya0ACgkQJNaLcl1U h9DDIAf+MtGt8tvS+CkPMWMjrGYCZDpoYTNSG8w7bxnZ5L6NsS7ar72k7HiRqVO/ pE+8kE3FNkOrwUFkpli5qwvdajWpwQSeCWpeV0eSDR0CccR5fe8uTP61ghxSeiH5 ugZICXyPPP5HBXx+pEltNNF5soqbhkTKFQuxtIOaj285oRpFUyoDmI+41+GoBZ01 o/UBnwpnD5m8gkR+cQs9Ev8jQC6e3IgAxZ+93XKGIgLYHjRNu0sQq70qKVDC7zO8 x7rmsv2UrO/yfu6KoCEtzlN8OSWNPKeJ7Q6fbAMomNvHoou45tjWGiPFcSyuh/Zr 5Y6zrB3VywfTAuIRBgoYdtSWmmNLBQ== =55/E -----END PGP SIGNATURE-----