Re: [PATCH] ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS

"Arnd Bergmann" <[email protected]> Sun, 16 Aug 2026 23:23:59 +0200

Newsgroups	org.kernel.vger.linux-sound,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Sun, Aug 16, 2026, at 23:11, Rosen Penev wrote:
> On Sat, Aug 15, 2026 at 5:01 PM Julian Braha <[email protected]> wrote:
>
> --- a/sound/soc/fsl/efika-audio-fabric.c
> +++ b/sound/soc/fsl/efika-audio-fabric.c
> @@ -22,8 +22,6 @@
>  #include <sound/initval.h>
>  #include <sound/soc.h>
>
> -#include "mpc5200_dma.h"
> -
>  #define DRV_NAME "efika-audio-fabric"
>
>  SND_SOC_DAILINK_DEFS(analog,
>
> compiles. That header indeed references bestcom stuff, but I don't see
> the driver doing so.

CONFIG_SND_MPC52xx_DMA is a hidden symbol that gets selected by the
drivers that use it (SND_SOC_MPC5200_I2S and SND_SOC_MPC5200_AC97).

SND_MPC52xx_SOC_EFIKA and SND_MPC52xx_SOC_PCM030 in turn select
SND_SOC_MPC5200_AC97, but that could probably be turned into
'depends on' since  SND_SOC_MPC5200_AC97 is a user visible
symbol.

     Arnd