Re: [PATCH v1 1/5] dt-bindings: sound: qcom,q6dsp-lpass-ports: Rename QAIF clock IDs
Prasad Kumpatla <[email protected]>
| Newsgroups | org.kernel.vger.linux-sound,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/11/2026 11:49 PM, Mark Brown wrote:
> On Sat, Aug 08, 2026 at 11:49:44PM +0530, Prasad Kumpatla wrote:
>> The QAIF clock IDs were added with a LAPSS prefix typo. These IDs are
>> new, so rename them directly to the existing LPASS naming convention
>> instead of keeping misspelled aliases.
> This breaks the build. *Please* test things before sending them.
Hi Mark,
The affected LPASS_CLK_ID references were updated in
patch 2, and I compiled and tested the series as a whole, so I missed that
patch 1 does not build independently. I'll combine patches 1 and 2 in the
next revision so the rename and all corresponding user updates are applied
together, ensuring the patch builds cleanly on its own.
If you have any suggestions on the preferred structure for this series,
please let me know.
a { text-decoration: none; color: #464feb; }tr th, tr td { border: 1px
solid #e6e6e6; }tr th { background-color: #f5f5f5; }
If you have any suggestions on the preferred structure for this series,
please let me know.
Thanks,
Prasad
>
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:67:19: error: ‘LAPSS_CLK_ID_QAIF_IF0_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF0_IBIT’?
> 67 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF0_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:68:19: error: ‘LAPSS_CLK_ID_QAIF_IF0_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF0_EBIT’?
> 68 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF0_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:69:19: error: ‘LAPSS_CLK_ID_QAIF_IF1_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF1_IBIT’?
> 69 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF1_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:70:19: error: ‘LAPSS_CLK_ID_QAIF_IF1_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF1_EBIT’?
> 70 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF1_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:71:19: error: ‘LAPSS_CLK_ID_QAIF_IF2_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF2_IBIT’?
> 71 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF2_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:72:19: error: ‘LAPSS_CLK_ID_QAIF_IF2_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF2_EBIT’?
> 72 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF2_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:73:19: error: ‘LAPSS_CLK_ID_QAIF_IF3_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF3_IBIT’?
> 73 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF3_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:74:19: error: ‘LAPSS_CLK_ID_QAIF_IF3_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF3_EBIT’?
> 74 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF3_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:75:19: error: ‘LAPSS_CLK_ID_QAIF_IF4_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF4_IBIT’?
> 75 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF4_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:76:19: error: ‘LAPSS_CLK_ID_QAIF_IF4_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF4_EBIT’?
> 76 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF4_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:77:19: error: ‘LAPSS_CLK_ID_QAIF_IF5_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF5_IBIT’?
> 77 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF5_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:78:19: error: ‘LAPSS_CLK_ID_QAIF_IF5_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF5_EBIT’?
> 78 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF5_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:79:19: error: ‘LAPSS_CLK_ID_QAIF_IF6_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF6_IBIT’?
> 79 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF6_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:80:19: error: ‘LAPSS_CLK_ID_QAIF_IF6_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF6_EBIT’?
> 80 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF6_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:81:19: error: ‘LAPSS_CLK_ID_QAIF_IF7_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF7_IBIT’?
> 81 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF7_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:82:19: error: ‘LAPSS_CLK_ID_QAIF_IF7_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF7_EBIT’?
> 82 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF7_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:83:19: error: ‘LAPSS_CLK_ID_QAIF_IF8_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF8_IBIT’?
> 83 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF8_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:84:19: error: ‘LAPSS_CLK_ID_QAIF_IF8_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF8_EBIT’?
> 84 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF8_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:85:19: error: ‘LAPSS_CLK_ID_QAIF_IF9_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF9_IBIT’?
> 85 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF9_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:86:19: error: ‘LAPSS_CLK_ID_QAIF_IF9_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF9_EBIT’?
> 86 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF9_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:87:19: error: ‘LAPSS_CLK_ID_QAIF_IF10_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF10_IBIT’?
> 87 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF10_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:88:19: error: ‘LAPSS_CLK_ID_QAIF_IF10_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF10_EBIT’?
> 88 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF10_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:89:19: error: ‘LAPSS_CLK_ID_QAIF_IF11_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF11_IBIT’?
> 89 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF11_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:90:19: error: ‘LAPSS_CLK_ID_QAIF_IF11_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF11_EBIT’?
> 90 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF11_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:91:19: error: ‘LAPSS_CLK_ID_QAIF_IF12_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF12_IBIT’?
> 91 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF12_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:92:19: error: ‘LAPSS_CLK_ID_QAIF_IF12_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_QAIF_IF12_EBIT’?
> 92 | Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF12_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:93:19: error: ‘LAPSS_CLK_ID_VA_QAIF_IF0_IBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_VA_QAIF_IF0_IBIT’?
> 93 | Q6PRM_CLK(LAPSS_CLK_ID_VA_QAIF_IF0_IBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:94:19: error: ‘LAPSS_CLK_ID_VA_QAIF_IF0_EBIT’ undeclared here (not in a function); did you mean ‘LPASS_CLK_ID_VA_QAIF_IF0_EBIT’?
> 94 | Q6PRM_CLK(LAPSS_CLK_ID_VA_QAIF_IF0_EBIT),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/sound/soc/qcom/qdsp6/q6prm-clocks.c:15:27: note: in definition of macro ‘Q6PRM_CLK’
> 15 | .clk_id = id, \
> | ^~