[PATCH v2 0/4] ASoC: mediatek: mt8186: Fix clock error handling

[email protected]
Newsgroups org.kernel.vger.linux-sound,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
From: bui duc phuc <[email protected]>

Hi all,

This series fixes clock error handling in the MT8186 AFE driver.

The current code may fail to clean up clocks that were already enabled and 
may not propagate some clock lookup errors.

I also referred to the MT8183 implementation, where the clocks are handled 
using devm_clk_get(). However, the MT8186 code currently behaves more like 
devm_clk_get_optional().

I could not find any indication that these clocks are optional, 
so I dropped patch 5 from v1. If this is confirmed, I can send the change 
as a separate patch in a later revision.

The changes were found by manual code inspection and compile-tested only.

Link v1 : 
https://lore.kernel.org/all/[email protected]/

Changes in v2:
 - Update the cover letter.
 - Drop patch 5 from v1.
 - Add Fixes tags.

Best regards,
Phuc
bui duc phuc (4):
  ASoC: mediatek: mt8186: fix APLL mux setting error handling
  ASoC: mediatek: mt8186: Fix AFE clock error handling
  ASoC: mediatek: mt8186: Fix APLL enable error handling
  ASoC: mediatek: mt8186: Fix MCK error handling

 sound/soc/mediatek/mt8186/mt8186-afe-clk.c | 103 ++++++++++++++-------
 1 file changed, 71 insertions(+), 32 deletions(-)

-- 
2.43.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.