Re: [PATCH v2 0/4] ASoC: add ESS Technology ES9039Q2M codec driver
Karl Asseily <[email protected]>
| Newsgroups | org.kernel.vger.linux-sound,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CA+gvwbomK1Vr4nXnFYa-g8PgVCisoQG8fJB_QpSHKU=GVDZa9A@mail.gmail.com> |
Two problems in the clocking rework, both flagged by the Sashiko review
bot on the devicetree side of this thread and both correct, so please do
not apply the series as it stands.
- es9039_setup_clocking() calls clk_set_rate() for 256 * FS
unconditionally. That is above the part's 50 MHz MCLK maximum for
anything over 192 kHz, and the rate clk_get_rate() returns is not
re-checked against it.
- The 128 * FS floor is applied regardless of 64FS mode, which the
datasheet puts at 64 * FS. Since 128 * 768000 is 98.304 MHz, the
768 kHz advertised in SNDRV_PCM_RATE_8000_768000 cannot be reached
at all.
Both are fixed in my tree, along with the mute and DoP controls moving their
shadow state before the I2C write rather than after it. I will hold v3
until the binding has had a review rather than resending straight away.
Karl