Re: [PATCH 2/3] xfs: move some code out of xfs_iget_recycle
Linus Torvalds <[email protected]>
| Newsgroups | org.kernel.vger.linux-sparse,org.kernel.vger.linux-kernel,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <CAHk-=whmYntzyDUOjmoyKR_oyzg9Gddnda447KioykKi3FmzDQ@mail.gmail.com> |
On Fri, 14 Nov 2025 at 09:06, Darrick J. Wong <[email protected]> wrote: > > I wonder, does sparse get confused by rcu_read_lock having been taken by > the caller but unlocked here? I think we'll sunset all the sparse lock context checks - they were never very good, but they were "all we had". It was useful in limited and simpler places (because the sparse logic itself was limited and simple), but it never worked well for anything more complex. Now that clang is about to get context checking, and doing it much more properly, the half-arsed sparse complaints should be ignored in favor of just trying to make clang understand things well enough. Put another way: don't worry about sparse. Linus