Re: make xfs sparse-warning free
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-sparse,org.kernel.vger.linux-kernel,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Nov 14, 2025 at 09:56:51AM -0800, Linus Torvalds wrote: > I know you looked at that clang context thing earlier, and assumed > that that is what triggered this work in the first place? In this case not directly, although patch 2 was originally done for that. Patch 1 is newer than those experiments, but only because we just started using lockref in this merge window, and it should apply for that as well. > > Patch 3 duplicates some XFS code to work around the lock context tracking, > > but I think it is pretty silly. > > makes me go "if you have to make the code worse to make sparse happy, > maybe just look at the clang context tracking instead?" Well, that's why I said I didn't like it it and included it more as an example for the sparse developers to see what goes wrong. > Because I *assume* that the more complete clang context tracking > series doesn't need that? I assume the same, but the quota changes the cause this are new, and I haven't combined them yet with the context tracking experiments I did a while ago.