Re: [PATCH v5 17/36] locking/rwsem: Support Clang's context analysis
Bart Van Assche <[email protected]> Fri, 19 Dec 2025 12:55:01 -0800
| Newsgroups | org.kernel.vger.linux-sparse,dev.linux.lists.llvm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-doc,org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel,org.kernel.vger.linux-security-module,org.kernel.vger.linux-wireless,org.kernel.vger.rcu,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 12/19/25 7:40 AM, Marco Elver wrote:
> static inline void rwsem_assert_held_nolockdep(const struct rw_semaphore *sem)
> + __assumes_ctx_lock(sem)
> {
> WARN_ON(atomic_long_read(&sem->count) == RWSEM_UNLOCKED_VALUE);
> }
>
> static inline void rwsem_assert_held_write_nolockdep(const struct rw_semaphore *sem)
> + __assumes_ctx_lock(sem)
> {
> WARN_ON(!(atomic_long_read(&sem->count) & RWSEM_WRITER_LOCKED));
> }
> @@ -119,6 +121,7 @@ do { \
> static struct lock_class_key __key; \
> \
> __init_rwsem((sem), #sem, &__key); \
> + __assume_ctx_lock(sem); \
> } while (0)
Just like as for lockdep.h, I think that the above annotations should be
changed into __must_hold().
Thanks,
Bart.