Re: [PATCH v5 22/36] um: Fix incorrect __acquires/__releases annotations
Bart Van Assche <[email protected]> Fri, 19 Dec 2025 13:05:56 -0800
| Newsgroups | org.kernel.vger.linux-sparse,dev.linux.lists.llvm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-doc,org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel,org.kernel.vger.linux-security-module,org.kernel.vger.linux-wireless,org.kernel.vger.rcu,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 12/19/25 7:40 AM, Marco Elver wrote:
> -void enter_turnstile(struct mm_id *mm_id) __acquires(turnstile)
> +struct mutex *__get_turnstile(struct mm_id *mm_id)
> {
> struct mm_context *ctx = container_of(mm_id, struct mm_context, id);
>
> - mutex_lock(&ctx->turnstile);
> + return &ctx->turnstile;
> }
Many "container_of()" wrappers have "to" in their name. Please follow
that convention and rename this function into e.g. mm_id_to_turnstile().
Thanks,
Bart.