Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues

Bagas Sanjaya <[email protected]> Tue, 6 Jun 2023 19:28:52 +0700

Newsgroups	org.kernel.vger.linux-spdx,org.kernel.vger.kernel-janitors,org.kernel.vger.keyrings,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Fri, Jun 02, 2023 at 10:59:02AM +0200, Franziska Naepelt wrote:
> The following issues are fixed:
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - ERROR: trailing statements should be on next line
> - WARNING: braces {} are not necessary for single statement blocks
> - ERROR: space required before the open parenthesis '('
> - ERROR: code indent should use tabs where possible
> - WARNING: please, no spaces at the start of a line
> - WARNING: Missing a blank line after declarations

Again, write the patch description in imperative mood (e.g. "Do foo").

> +// SPDX-License-Identifier: LGPL-2.1
>  /* Extract X.509 certificate in DER form from PKCS#11 or PEM.
>   *
>   * Copyright © 2014-2015 Red Hat, Inc. All Rights Reserved.

Nope.

The license boilerplate says LGPL 2.1 or any later version, so the
corresponding SPDX tag should have been:

```
// SPDX-License-Identifier: LGPL-2.1-or-later
```

And please also delete the boilerplate and separate this SPDX conversion
into its own patch.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

signature.asc (application/pgp-signature, 228 B)