Re: [PATCH] spi: orion: use devm_clk_get_optional_enabled for axi clock

Mark Brown <[email protected]>
Newsgroups org.kernel.vger.linux-spi,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Wed, Jul 15, 2026 at 03:13:43PM -0700, Rosen Penev wrote:
> Replace the open-coded optional axi clock get/prepare/enable and the
> manual cleanup in probe/remove/runtime_resume with the managed helper
> devm_clk_get_optional_enabled(). This removes the now-unused
> out_rel_axi_clk error path and simplifies the clock lifecycle.

> @@ -804,7 +796,6 @@ static void orion_spi_remove(struct platform_device *pdev)
>  	spi_unregister_controller(host);
>  
>  	pm_runtime_get_sync(&pdev->dev);
> -	clk_disable_unprepare(spi->axi_clk);
>  
>  	pm_runtime_disable(&pdev->dev);
>  	pm_runtime_put_noidle(&pdev->dev);

This breaks the build since it removes the only use of 'spi' in the
function.
signature.asc (application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpZDREACgkQJNaLcl1U
h9CL/gf+KUsYZPrmkE56rnp4xpA43aKu3YSiFv8BVolsrhYLaABH20+duF4/uQGn
IpEFd3/qAzfb04dKWhqpHaJxRzNgveMUHJVyu7GcXziQxAFpRMQ8dG3WY3iRVNOQ
iXSq1ejjuhPNHvu22DSl+xFi6O5d9H0ToUV5irxTH1bxM9CJ41pYl4Q97TtP/MTz
w3PbBXCr/PmIYMPX6CDoHu1K7QaDagSRTl8H1uJRyLTwRf5ze2J5WOvR72HhD2rZ
Lkyb2/537RSLapkVEIVIXnUcwzrExBeFPHkGsviioKA2P+5dT48X9DrqF0HeD2ZD
6Tx0C/F9MTAu+N8Lt8SHRmN9jZ/Oww==
=hPzx
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.