Re: [PATCH v5 01/17] spi: dt-bindings: add spi-max-post-config-frequency-hz property
Santhosh Kumar K <[email protected]>
| Newsgroups | org.kernel.vger.linux-spi,org.infradead.lists.linux-mtd,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello Krzysztof, On 19/07/26 12:23, Krzysztof Kozlowski wrote: > On Sat, Jul 18, 2026 at 12:21:00AM +0530, Santhosh Kumar K wrote: >> Add spi-max-post-config-frequency-hz, a generic property for SPI >> peripherals that operate at two distinct clock rates: a conservative >> rate always reachable without controller configuration, and a higher >> rate achievable only after controller-side configuration. >> >> When both properties are present, spi-max-frequency gives the >> conservative pre-configuration rate and spi-max-post-config-frequency-hz >> gives the higher post-configuration target. >> >> Acked-by: Conor Dooley <[email protected]> >> Signed-off-by: Santhosh Kumar K <[email protected]> >> --- >> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml >> index 880a9f624566..12211f8c9f7d 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml >> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml >> @@ -45,6 +45,11 @@ properties: >> description: >> Maximum SPI clocking speed of the device in Hz. >> >> + spi-max-post-config-frequency-hz: >> + description: >> + Maximum SPI clock frequency in Hz achievable after controller-side >> + configuration. > > How did you implement my feedback? Three points from your feedback: 1. -hz suffix: added 2. Array property: I still lean towards keeping this as a scalar for now, as we don't have a concrete use case for multiple values today, and supporting two frequencies should be sufficient for the foreseeable future. I had responded to this in the v4 discussion as well, you may have missed that response. 3. maxItems: Since the property remains a scalar, I have not added maxItems. Thanks, Santhosh. > > Best regards, > Krzysztof >