Re: [PATCH v16 7/7] spi: pxa2xx: rename local status variable to ret

"Shih-Yuan Lee (FourDollars)" <[email protected]> Sun, 26 Jul 2026 19:23:33 +0800

Newsgroups	org.kernel.vger.linux-spi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel
Message-ID	<CAAT15mNfnXh4CDAwQjtH8ktLuah4r+LBgUfm8m-6p-fMOkp2Kg@mail.gmail.com>

On Tue, Jul 21, 2026 at 3:56 AM Andy Shevchenko
<[email protected]> wrote:
>
> On Tue, Jul 21, 2026 at 12:21:16AM +0800, Shih-Yuan Lee wrote:
> > Rename the return value variable name from 'status' to 'ret' in the
> > pxa2xx_spi_probe(), pxa2xx_spi_suspend(), pxa2xx_spi_resume(), and
> > pxa2xx_spi_runtime_resume() functions to conform to standard Linux kernel
> > coding conventions.
>
Hi Andy,
> It makes a ping-pong style of changes: Previous patches add more status uses
> and moves, and so on. Instead, this patch should go before all that.
Agreed. I have reordered the patch series for the next version so that
"spi: pxa2xx: rename local status variable to ret" is placed near the
front, eliminating all ping-pong diff churn.

Thanks,
Shih-Yuan