Re: [PATCH v4 2/2] spi: ma35d1-qspi: Add Nuvoton MA35D1 QSPI controller support

Mark Brown <[email protected]> Thu, 30 Jul 2026 16:11:31 +0100

Newsgroups	org.kernel.vger.linux-spi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Mon, Jul 27, 2026 at 05:18:33PM +0800, Chi-Wen Weng wrote:

> Add SPI controller driver support for the Quad SPI controller found in
> Nuvoton MA35D1 SoCs.

> +static int nuvoton_qspi_mem_exec_op(struct spi_mem *mem,
> +				    const struct spi_mem_op *op)
> +{

> +	if (op->dummy.nbytes) {
> +		nuvoton_qspi_set_bus_width(qspi, op->dummy.buswidth,
> +					   SPI_MEM_DATA_IN);
> +		ret = nuvoton_qspi_txrx(qspi, NULL, NULL, op->dummy.nbytes);
> +		if (ret)
> +			goto out_deassert_cs;
> +	}

I would expect dummy data to be an output rather than an input, we don't
want the lines left floating?  There's a similar thing below when
setting up the dummy xfer.

signature.asc (application/pgp-signature, 488 B)