Re: [PATCH] spi: dt-bindings: sun6i: Add compatibles for A733's SPI controllers
Jerome Brunet <[email protected]>
| Newsgroups | org.kernel.vger.linux-spi,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On mer. 05 août 2026 at 21:08, Andre Przywara <[email protected]> wrote: > On Wed, 05 Aug 2026 15:53:26 +0200 > Jerome Brunet <[email protected]> wrote: > >> The A733 has six SPI controllers with the same IP as the A523. >> Like the A523, one of them (spi1) also supports DBI mode. >> >> Add SoC specific compatible strings, falling back to the A523 ones. > > Has this been tested? Can someone confirm? We should avoid adding > bindings prematurely, not that it bites us again as it did for the H616 > DE bindings, for instance. Yes it was. There is SPI-NOR on the cubie A7A. I did a quick sanity check on it to verify it was functional (writing and reading back). I should probably have added an note about that. I have been submit a few changes like one lately. I'm doing that so we can get on with DT as soon as possible, without waiting on the bindings. I would normally submit the corresponding DT change at the same time but DT is currently blocked by the main CCU and pinctrl. > > Cheers, > Andre > > >> >> Signed-off-by: Jerome Brunet <[email protected]> >> --- >> Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml >> index 6af4ff233158..be47c6e00409 100644 >> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml >> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml >> @@ -36,6 +36,13 @@ properties: >> - items: >> - const: allwinner,sun55i-a523-spi-dbi >> - const: allwinner,sun55i-a523-spi >> + - items: >> + - const: allwinner,sun60i-a733-spi >> + - const: allwinner,sun55i-a523-spi >> + - items: >> + - const: allwinner,sun60i-a733-spi-dbi >> + - const: allwinner,sun55i-a523-spi-dbi >> + - const: allwinner,sun55i-a523-spi >> >> reg: >> maxItems: 1 >> >> --- >> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 >> change-id: 20260805-allwinner-a733-spi-support-e30a9ac057a3 >> >> Best regards, >> -- >> Jerome >> >> -- Jerome