Re: [PATCH 1/2] dt-bindings: spi: qcom-geni: Document device-gpios property
Praveen Talari <[email protected]>
| Newsgroups | org.kernel.vger.linux-spi,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Mukesh, On 06-08-2026 23:45, Mukesh Savaliya wrote: > > > On 8/6/2026 3:43 PM, Praveen Talari wrote: >> When operating in SPI target (slave) mode, the GENI SPI controller can >> use an external GPIO to notify the SPI master about the target's >> active state. >> > > Is this active state meaning target is in ready state to communicate > with master controller ? Yes, you are right. > > When will it set this gpio ? can you describe little ? I have already described the behaviour in the driver change. Is additional explanation required in the DT binding as well? > >> Document the optional device-gpios property for the qcom,spi-geni-qcom > seems bit generic name, it should describe the signal purpose, not the > device. Something like handshake-gpios OR ready-gpios ? As mark pointed, there is already ready-gpios so i use this. >> and qcom,sa8255p-geni-spi bindings, restricted to spi-slave nodes. >> >> Signed-off-by: Praveen Talari <[email protected]> >> --- >> Documentation/devicetree/bindings/spi/qcom,sa8255p-geni-spi.yaml | 9 >> +++++++++ >> Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 9 >> +++++++++ >> 2 files changed, 18 insertions(+) > > [...]