Re: [PATCH v2] spi: tegra114: initialize native chip selects inactive

Abraham Zukor <[email protected]>
Newsgroups org.kernel.vger.linux-spi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-tegra
Message-ID <[email protected]>
On Fri, Jul 31, 2026 at 04:13:31PM +0900, Mikko Perttunen wrote:
> I don't think this is a problem, as the device tree is supposed to
> describe the visible hardware.

Fair, I noticed it when testing, so I figured I should bring it up.

> Why do we need to consider cs-gpios? If a device has a cs-gpio,
> whatever we program here wouldn't reach the device.

To maintain signal for signal backwards compatibility, I kept the
(unused) native CS lines low. Nothing should be using those lines, so I
will drop it in v3 unless you say otherwise.

> The if condition is also very difficult to read -- please use multiple
> if statements and normal error  handling patterns.

Will fix in V3.

Thanks,
Abe
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.