Re: [PATCH v3 6/6] iio: adc: ad7768-1: add support for multiple chip aggregation

Nuno Sá <[email protected]>
Newsgroups org.kernel.vger.linux-spi,org.kernel.vger.linux-kernel
Message-ID <178706987295.3163.11524351499173013451.b4-review@b4>
On Mon, 17 Aug 2026 20:33:41 -0300, Jonathan Santos <[email protected]> wrote:
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index e9060c1bbe6f..deff36165ed1 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -1830,6 +1892,15 @@ static int ad7768_probe(struct spi_device *spi)
>  
>  	st->chip = spi_get_device_match_data(spi);
>  	st->spi = spi;
> +	/*
> +	 * This family is composed of single-lane devices, so we assume that
> +	 * each lane is bound to a different device.
> +	 */
> +	st->num_devices = spi->num_rx_lanes;

I still don't agree with the above! At the very least we should infer
st->num_devices from the number of chipselects. Anyways, won't extend
much the review for now given that David seems to have some ideas
different from the ancillary devices.

- Nuno Sá

-- 
Nuno Sá <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.