Re: [PATCH] media: cec: tegra: add missing MODULE_DEVICE_TABLE()

Mikko Perttunen <[email protected]>
Newsgroups org.kernel.vger.linux-tegra,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media
Message-ID <[email protected]>
On Saturday, July 4, 2026 9:26 PM Pengpeng Hou wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
> 
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
> 
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.

This paragraph doesn't belong in the commit message. Below the three
dashes you can simply say that the patch is only build-tested. No
elaborate AI patch justifications necessary.

> 
> Signed-off-by: Pengpeng Hou <[email protected]>
> ---
>  drivers/media/cec/platform/tegra/tegra_cec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c
> index 3ed50097262f..fe66336e734f 100644
> --- a/drivers/media/cec/platform/tegra/tegra_cec.c
> +++ b/drivers/media/cec/platform/tegra/tegra_cec.c
> @@ -458,6 +458,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
>  	{ .compatible = "nvidia,tegra210-cec", },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, tegra_cec_of_match);
>  
>  static struct platform_driver tegra_cec_driver = {
>  	.driver = {
> 
> 

Otherwise looks fine to me.

Mikko
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.