Re: [PATCH] firmware: tegra: Remove redundant dev_err()
Mikko Perttunen <[email protected]>
| Newsgroups | org.kernel.vger.linux-tegra,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Monday, July 13, 2026 10:19 PM Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <[email protected]>
> ---
> drivers/firmware/tegra/bpmp-tegra210.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c
> index 6295f5640c15..643068a8b3b8 100644
> --- a/drivers/firmware/tegra/bpmp-tegra210.c
> +++ b/drivers/firmware/tegra/bpmp-tegra210.c
> @@ -215,10 +215,8 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp)
>
> err = devm_request_irq(&pdev->dev, err, rx_irq,
> IRQF_NO_SUSPEND, dev_name(&pdev->dev), bpmp);
> - if (err < 0) {
> - dev_err(&pdev->dev, "failed to request IRQ: %d\n", err);
> + if (err < 0)
> return err;
> - }
>
> return 0;
> }
> --
> 2.34.1
>
>
Reviewed-by: Mikko Perttunen <[email protected]>