Re: [PATCH net v3] net: stmmac: enable the MAC on link up for all supported speeds
Jakub Kicinski <[email protected]> Tue, 21 Jul 2026 15:42:33 -0700
| Newsgroups | org.kernel.vger.linux-tegra,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 13 Jul 2026 10:49:11 +0300 vadik likholetov wrote: > stmmac_mac_link_down() clears the MAC's transmit and receive enable bits. > stmmac_mac_link_up() is expected to set them again through > stmmac_mac_set(..., true), but it first switches on the negotiated speed > and returns early for a speed the switch does not list. The MAC is then > left gated off. FWIW Sashiko has some complaints: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/[email protected] but that reads as a separate issue?