[PATCH RESEND] staging: nvec: use strcmp() instead of strncmp() with magic length
Artem Lytkin <[email protected]> Thu, 23 Jul 2026 19:18:23 +0300
| Newsgroups | org.kernel.vger.linux-tegra,dev.linux.lists.linux-staging |
|---|---|
| Message-ID | <[email protected]> |
Replace strncmp() with a hardcoded length of 30 with strcmp(). The bat_type string is already null-terminated (set two lines above), so strncmp() with an arbitrary length is misleading and functionally equivalent to strcmp(). Signed-off-by: Artem Lytkin <[email protected]> --- drivers/staging/nvec/nvec_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c index 2faab9fdedef7..89dd997aaf36b 100644 --- a/drivers/staging/nvec/nvec_power.c +++ b/drivers/staging/nvec/nvec_power.c @@ -207,7 +207,7 @@ static int nvec_power_bat_notifier(struct notifier_block *nb, * This differs a little from the spec fill in more if you find * some. */ - if (!strncmp(power->bat_type, "Li", 30)) + if (!strcmp(power->bat_type, "Li")) power->bat_type_enum = POWER_SUPPLY_TECHNOLOGY_LION; else power->bat_type_enum = POWER_SUPPLY_TECHNOLOGY_UNKNOWN; -- 2.43.0