Re: [PATCH v8 2/3] iommu/arm-smmu-v3: Introduce CFGI/TLBI-repeat workaround infrastructure

Ashish Mhetre <[email protected]> Fri, 24 Jul 2026 09:53:21 +0530

Newsgroups	org.kernel.vger.linux-tegra,dev.linux.lists.iommu,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>


On 7/23/2026 12:32 AM, Nicolin Chen wrote:
> On Wed, Jul 22, 2026 at 10:20:32AM +0000, Ashish Mhetre wrote:
>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
>> index c909c9a88538..9508bf50d14c 100644
>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
>> @@ -1207,10 +1207,15 @@ void arm_smmu_attach_commit(struct arm_smmu_attach_state *state);
>>   int arm_smmu_cmdq_issue_cmdlist(struct arm_smmu_device *smmu,
>>   				struct arm_smmu_cmdq *cmdq,
>>   				struct arm_smmu_cmd *cmds, int n,
>>   				bool sync);
>> +bool arm_smmu_erratum_cmd_needs_repeating(struct arm_smmu_cmd *cmd);
>   
> Is this needed?
>
> Nicolin

It isn’t, thanks for pointing out. After dropping arm_vsmmu_can_batch_cmd(),
that helper is only used inside arm-smmu-v3.c, so it should become 
static there
and be removed from the header.

Thanks,
Ashish Mhetre