Re: [PATCH v2 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration

Svyatoslav Ryhel <[email protected]> Tue, 28 Jul 2026 17:08:40 +0300
Newsgroups org.kernel.vger.linux-tegra,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <CAPVz0n2AOJ_rcsCEhVQWUq1fXtd7kXkE9yScY1VwGyZefz50Uw@mail.gmail.com>
=D0=B2=D1=82, 28 =D0=BB=D0=B8=D0=BF. 2026=E2=80=AF=D1=80. =D0=BE 15:13 Mikk=
o Perttunen <[email protected]> =D0=BF=D0=B8=D1=88=D0=B5:
>
> On Tuesday, July 21, 2026 7:10=E2=80=AFPM Svyatoslav Ryhel wrote:
> > Drop reset GPIO from bluetooth part. Add lpo clock to both WiFi and
> > bluetooth nodes. Add 'brcm,bcm43340-fmac' as primary compatible and
> > 'brcm,bcm4329-fmac' remains as fallback.
> >
> > Signed-off-by: Svyatoslav Ryhel <[email protected]>
> > ---
> >  arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/a=
rm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > index 3de5c84d5f009..b71a02b3fd86f 100644
> > --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > @@ -1300,8 +1300,9 @@ bluetooth {
> >                       compatible =3D "brcm,bcm4334-bt";
> >                       max-speed =3D <4000000>;
> >
> > -                     clocks =3D <&tegra_pmc TEGRA_PMC_CLK_BLINK>;
> > -                     clock-names =3D "txco";
> > +                     clocks =3D <&tegra_pmc TEGRA_PMC_CLK_BLINK>,
> > +                              <&palmas_clk32k>;
> > +                     clock-names =3D "txco", "lpo";
> >
> >                       interrupt-parent =3D <&gpio>;
> >                       interrupts =3D <TEGRA_GPIO(U, 6) IRQ_TYPE_EDGE_RI=
SING>;
> > @@ -1309,7 +1310,6 @@ bluetooth {
> >
> >                       device-wakeup-gpios =3D <&gpio TEGRA_GPIO(EE, 1) =
GPIO_ACTIVE_HIGH>;
> >                       shutdown-gpios =3D <&gpio TEGRA_GPIO(Q, 7) GPIO_A=
CTIVE_HIGH>;
> > -                     reset-gpios =3D <&gpio TEGRA_GPIO(Q, 6) GPIO_ACTI=
VE_LOW>;
>
> I'd appreciate a note in the commit message on why this is dropped.
>

It does not comply schema for "brcm,bcm4334-bt", further testing with
this reset gpio removed confirmed that it has nothing to do with
bluetooth and bluetooth works just fine without it.

> >
> >                       vbat-supply =3D <&vdd_3v3_com>;
> >                       vddio-supply =3D <&vdd_1v8_vio>;
> > @@ -1450,7 +1450,7 @@ palmas_gpio: gpio {
> >                               #gpio-cells =3D <2>;
> >                       };
> >
> > -                     palmas_clk32kg@0 {
> > +                     palmas_clk32k: palmas_clk32kg@0 {
> >                               compatible =3D "ti,palmas-clk32kg";
> >                               #clock-cells =3D <0>;
> >                       };
> > @@ -2382,9 +2382,12 @@ mmc@78000000 {
> >               vqmmc-supply =3D <&vdd_1v8_vio>;
> >
> >               wifi@1 {
> > -                     compatible =3D "brcm,bcm4329-fmac";
> > +                     compatible =3D "brcm,bcm43340-fmac", "brcm,bcm432=
9-fmac";
> >                       reg =3D <1>;
> >
> > +                     clocks =3D <&palmas_clk32k>;
> > +                     clock-names =3D "lpo";
> > +
> >                       interrupt-parent =3D <&gpio>;
> >                       interrupts =3D <TEGRA_GPIO(U, 5) IRQ_TYPE_LEVEL_H=
IGH>;
> >                       interrupt-names =3D "host-wake";
> > --
> > 2.53.0
> >
> >