Re: [PATCH] spi: tegra114: initialize native chip selects inactive
Mark Brown <[email protected]> Wed, 29 Jul 2026 11:14:00 +0100
| Newsgroups | org.kernel.vger.linux-tegra,org.kernel.vger.linux-kernel,org.kernel.vger.linux-spi |
|---|---|
| Message-ID | <[email protected]> |
--Cde329U7yPqeTeFs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 28, 2026 at 10:09:43PM +0100, Jon Hunter wrote: > On 28/07/2026 21:03, Abraham Zukor wrote: > > I think that defaulting to active-low is correct. The Tegra234 SPI > > controller hardware defaults to active-low (all bits in CS_POL_INACTIVE > > are set) so an active-high device is already asserted before this driver > > initializes. I checked the controller drivers under drivers/spi/; they > > either default to active-low or preserve the hardware default. > I am a bit reluctant to make this change after 10+ years of this driver > being around. Yeah, I'd not be surprised to run into existing systems that somehow manage to rely on the current behaviour. --Cde329U7yPqeTeFs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpp0mcACgkQJNaLcl1U h9Dnvwf+I/lKyRrYbNSnmb1kNGVIVtI91/wWdmNRaO896sp6sPB7jB7C0KlELyiL S7lDuyAGhgRiUjXDLmXGsFNfTkt1lYWFlAiNGHBv8DmUh2jnrSmmdbnIke2GDWVw nwFOS/+WalRPr5BbhTYjNQpPbxOvElbzoVM+b7eh4WhQQdu/kJ8pPjf5g84/AQey jfQy1PWqHdDCkKXkCR3EbrMaMaFMO9p9wo+5l5XgomBXZv0qFiKfusr9ZFvBtnXK +JT+klHSk3IyEm11/yQ4Lr5G0knV3NMprLHCRv1qDXAFZF427wsBpitNdqxOzZZ+ eo5egEx4r5D6NNCtY7bYM6tVxlK5zQ== =qVl/ -----END PGP SIGNATURE----- --Cde329U7yPqeTeFs--