Re: [PATCH v2 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration

--ga5mcv6lvh6lhfun
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip
 configuration
MIME-Version: 1.0

On Tue, Jul 28, 2026 at 05:08:40PM +0300, Svyatoslav Ryhel wrote:
> =D0=B2=D1=82, 28 =D0=BB=D0=B8=D0=BF. 2026=E2=80=AF=D1=80. =D0=BE 15:13 Mi=
kko Perttunen <[email protected]> =D0=BF=D0=B8=D1=88=D0=B5:
> >
> > On Tuesday, July 21, 2026 7:10=E2=80=AFPM Svyatoslav Ryhel wrote:
> > > Drop reset GPIO from bluetooth part. Add lpo clock to both WiFi and
> > > bluetooth nodes. Add 'brcm,bcm43340-fmac' as primary compatible and
> > > 'brcm,bcm4329-fmac' remains as fallback.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <[email protected]>
> > > ---
> > >  arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts | 13 ++++++++-----
> > >  1 file changed, 8 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch=
/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > > index 3de5c84d5f009..b71a02b3fd86f 100644
> > > --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > > +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > > @@ -1300,8 +1300,9 @@ bluetooth {
> > >                       compatible =3D "brcm,bcm4334-bt";
> > >                       max-speed =3D <4000000>;
> > >
> > > -                     clocks =3D <&tegra_pmc TEGRA_PMC_CLK_BLINK>;
> > > -                     clock-names =3D "txco";
> > > +                     clocks =3D <&tegra_pmc TEGRA_PMC_CLK_BLINK>,
> > > +                              <&palmas_clk32k>;
> > > +                     clock-names =3D "txco", "lpo";
> > >
> > >                       interrupt-parent =3D <&gpio>;
> > >                       interrupts =3D <TEGRA_GPIO(U, 6) IRQ_TYPE_EDGE_=
RISING>;
> > > @@ -1309,7 +1310,6 @@ bluetooth {
> > >
> > >                       device-wakeup-gpios =3D <&gpio TEGRA_GPIO(EE, 1=
) GPIO_ACTIVE_HIGH>;
> > >                       shutdown-gpios =3D <&gpio TEGRA_GPIO(Q, 7) GPIO=
_ACTIVE_HIGH>;
> > > -                     reset-gpios =3D <&gpio TEGRA_GPIO(Q, 6) GPIO_AC=
TIVE_LOW>;
> >
> > I'd appreciate a note in the commit message on why this is dropped.
> >
>=20
> It does not comply schema for "brcm,bcm4334-bt", further testing with
> this reset gpio removed confirmed that it has nothing to do with
> bluetooth and bluetooth works just fine without it.

Maybe this should be a separate patch to make it obvious that this fixes
a DTB validation issue. At the very least the commit message should say
that this drop the reset GPIO because it's not part of the binding.

Thierry

--ga5mcv6lvh6lhfun
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmpp1ZsACgkQ3SOs138+
s6H/jA/6A+LhbnWqfz2ebRYs1q/s2nfQ/3ghGoZQX7QJhicTGDD7RWAHV/uyIWja
QorCQRdZ1vQy/tiex78wleEwh5Rw8Dk5S6UZAerpKs9Lbg8z7HTECVDlB8P+hFaN
+Bp4vek4GYqQh+9PlJXBgzCroWBhcXDaq1NxkGGVaE3DMpi8L1B+dhzTa0EDNash
RhQkj6pHl631ZuENEX6E0lA5tnEFo/YjxWiIDOmb6Av0iH7xl7bJlEw+66eC9Sth
sfMcnoJnnsDbM+UO2iCO7xaqzDur6jmg+xdvXDTFtn3Gpk2hDuUpm+lRK3Xy8War
Zf6fzomo+WJ/w9Y9p0sZ3TmFs8wRUNzHs6olgoB1p3uFoDZlIDJZLxKIixUcsd1U
Uqqjj0/btfqknKh+jS35Sl/zBZd+adBR86kGIl2ZXYQEt3z5WWcE7787eSK8Evhf
WEBPyZZDXN2tiJsMwvQp+MW4R9AVLbCFWIRL7F3m8uidwNuXxcAVFWyzdmzx78y0
bhdt5iGh2mEuhPL3Jsj8SEfEFGQ46A/Cwd0iArqEBs2ULN5LAZioKP8hdqYqeTTQ
SiZ8wb8mGYyA4eC4ZLRUz03Rk7r79K4hCoL8xxTOE8dCFXuTxWS2ir/klE+zIYpm
X6PcnID08YGflsfur4aRubbhV0y5Js4mfqdq7tnHmtLvuPxfnyk=
=e4Xt
-----END PGP SIGNATURE-----

--ga5mcv6lvh6lhfun--