Re: [RESEND V2 2/2] pinctrl: tegra264: fix DAP2 DIN/DOUT pin assignment

--a7ft3u4zfnwsefvs
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [RESEND V2 2/2] pinctrl: tegra264: fix DAP2 DIN/DOUT pin
 assignment
MIME-Version: 1.0

On Mon, Jul 27, 2026 at 02:11:21PM +0000, Prathamesh Shete wrote:
> The dap2_din and dap2_dout pin groups were given swapped ball suffixes:
> DAP2_DIN was described as ball PV7 and DAP2_DOUT as ball PW0. On silicon
> DAP2_DIN is on ball PW0 (mux register 0x6050, drive register 0x6054) and
> DAP2_DOUT is on ball PV7 (mux register 0x6058, drive register 0x605c),
> as reflected by the board pinmux.
>=20
> Because the ball suffixes were swapped, the groups were also assigned the
> wrong primary mux functions (dap2_din -> I2S2_SDATA_OUT and dap2_dout ->
> I2S2_SDATA_IN), routing the I2S2 data-in and data-out signals to the wrong
> pins and breaking DAP2 audio.=20
>=20
> Rename the groups to dap2_din_pw0 and dap2_dout_pv7 and give each pad its
> correct function (dap2_din_pw0 -> I2S2_SDATA_IN, dap2_dout_pv7 ->
> I2S2_SDATA_OUT). The register offsets are already correct and are left
> unchanged. This matches the board pinmux.
>=20
> Fixes: c98506206912 ("pinctrl: tegra: Add Tegra264 pinmux driver")
> Signed-off-by: Prathamesh Shete <[email protected]>
> ---
> Changes in v2:
> - Rename the pin groups to dap2_din_pw0 and dap2_dout_pv7 and assign the
>   correct mux function to each pad in a single driver patch.
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra264.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Acked-by: Thierry Reding <[email protected]>

--a7ft3u4zfnwsefvs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmpsV3kACgkQ3SOs138+
s6FLjRAAryo5yUCe16ev9Hsp5w/uTh6I+6ZqQinCTL84ZWF2ogn8Qg5CicD2MSIa
vrHucgILo6nf7OK9xEeN8B45zX86KrOIKfz/PhDjNqq/zTuoO95++Z199ECEctbK
HGESN1vVagxuTLPAqNonoAiDPlMiL7N1H0eOEyOriASbPPEu72dmGktyqn19STIo
NGIq6BJNKKiqJl+3Td104FZynISwwIMS256jsBVMq46kdciYTYniEq5xYBLj/orm
FJcL1BY3y+/MuBGEKdBvhuI7WulQ9Kvi0xEdyi+aP7ZP+RSocH5z4dg5Wk/nVd6U
nFPYqgfMZfRvMHEm1PfDWtBm1fnHCbeLAxb/NKqDAHsVqi5LavFBiJRJXtegslBb
g7COhQPfkYje5v+zQTi7qdUru9XdY71PzdlXZuYAPmGgWfF/sK1fg+4XjPZ5DPnQ
QJo2UoPTd27DHf22LfoujCGIDD5tYPWvcGwAm/aHWcqiVGX7hUHaG2WWCEIrmsWN
bgH1HTJxkqTneZPvAsGBnAnvReHYNBmkSXcWnaSU+nHD5vv8LdcMvvQsmO2o72Yt
Dt+0xfDmYlyk6A32ex0bNbuVtxUECxBK4+jfpceJEGBvHz4DTArrWnyxRDxUPg65
I0BAEdeHLa6mMLzqE4sZIPaZq3zHcEyoipuDNdzwYZOaAAIuTzo=
=t+FL
-----END PGP SIGNATURE-----

--a7ft3u4zfnwsefvs--