Re: [PATCH 05/11] usb: gadget: Remove redundant dev_err()

Herve Codina <[email protected]> Sat, 1 Aug 2026 00:41:43 +0200

Newsgroups	org.kernel.vger.linux-tegra,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-usb,org.ozlabs.lists.linux-aspeed
Organization	Bootlin
Message-ID	<[email protected]>

Hi Pan,

On Fri, 31 Jul 2026 11:54:39 +0800
Pan Chuang <[email protected]> wrote:

> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"),
> devm_request_irq() and devm_request_threaded_irq() automatically log
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <[email protected]>
> ---
>  drivers/usb/gadget/udc/aspeed-vhub/core.c | 4 +---
>  drivers/usb/gadget/udc/aspeed_udc.c       | 4 +---
>  drivers/usb/gadget/udc/atmel_usba_udc.c   | 5 +----
>  drivers/usb/gadget/udc/r8a66597-udc.c     | 4 +---
>  drivers/usb/gadget/udc/renesas_usbf.c     | 8 ++------
>  drivers/usb/gadget/udc/snps_udc_plat.c    | 4 +---
>  drivers/usb/gadget/udc/tegra-xudc.c       | 5 +----
>  7 files changed, 8 insertions(+), 26 deletions(-)
> 

LGTM for renesas_usbf.c.

Reviewed-by: Herve Codina <[email protected]> # renesas_usbf.c

Best regards,
Hervé