Re: [RESEND V2 1/2] dt-bindings: pinctrl: tegra264: fix DAP2 DIN/DOUT pin names

--7dmww3t3gldfvauc
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [RESEND V2 1/2] dt-bindings: pinctrl: tegra264: fix DAP2
 DIN/DOUT pin names
MIME-Version: 1.0

On Tue, Aug 04, 2026 at 09:37:14AM +0200, Krzysztof Kozlowski wrote:
> On Mon, Jul 27, 2026 at 02:11:20PM +0000, Prathamesh Shete wrote:
> > The DAP2_DIN and DAP2_DOUT pins were listed with swapped ball suffixes:
> > DAP2_DIN as PV7 and DAP2_DOUT as PW0. On silicon DAP2_DIN is on ball PW0
> > and DAP2_DOUT is on ball PV7. Correct the pin and drive group names to
> > dap2_din_pw0 and dap2_dout_pv7.
> >=20
> > Fixes: 30a9d5162f25 ("dt-bindings: pinctrl: Document Tegra264 pin contr=
ollers")
> > Signed-off-by: Prathamesh Shete <[email protected]>
>=20
> This will break the users and only for fixing naming style? Are you sure
> it is worth beraking ABI?

This isn't just fixing the naming style, it's fixing the name of the
pins as they are referred to in a number of different places. With the
wrong ball suffix people might easily be confused as to what pin they
should be using.

So yes, I'd consider this a bug fix and worth an ABI break. The ABI
break is theoretical, too. This pin is currently not listed in any
upstream DTS files and all of the downstream ones I've seen use the
corrected suffix already.

Thierry

--7dmww3t3gldfvauc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmpy5c8ACgkQ3SOs138+
s6F5DA/+IrFkU31Db/Yvs5683Vc1LuVALU/xZKRm37wV4wmbHIZFgh3JYuUyyHuw
r1MOWNtGDZamdBb75IEmHmGYl9ts0vvBK12A5jTH4hrz2a0KTu/63Ic1jWZmx/tE
Es8DLhlUNUZVWS3mYv6+YDb0yB9CXa/2klCusLcovv9HjkaZAEZoJ02MHzuy6QVc
DLWvAzzOVtJV0bDHJfZ8hsWFcwPgmQw12nH6MO7kteb9pcvLi5yHb0CqsW8ku3sM
iMgap+H3x9ZMrbmBxNL2JGjsQ/dKiVqhFy34j+QLjCvx5GTmLNOShCxh2LGCUfUk
6b+8dfdLhnrLllInS21g57RR2h1pPuNPu2ppUkXSonZfVDhBSlndcv4/rnNMtl05
ccPgs7sWSnzyP7E58Mnd1bMHblePWlgUEbLmCjkI/Amzp3AWI+I0t3WVajMvWVIP
EI9OFnuVys3PEd0I1CH6fJRPk1h6mxqdKdbyjTIUlaaR/5xGH3NK5ga3jY5HmFHg
wH4Ly95OrehRk/nNwwftG9OnBpSfiBwkPp+4aJsHxw3dT96lWOOMYKhmjA0FnmzI
EP7Mgwr6Pe3k5lhLIu7VWdrOWCHtxpOcFpUESUdBDiRSlbbRUbozXLrk+LuAllDt
wf/X0ew6p6LoonVJ56tri3TKcTiGHEl+yeXIZuvkKdQf2+8Y3Hk=
=58Ro
-----END PGP SIGNATURE-----

--7dmww3t3gldfvauc--