Re: [PATCH v3 00/19] unwind, perf: sframe user space unwinding

On Mon, Oct 28, 2024 at 02:47:27PM -0700, Josh Poimboeuf wrote:
> This has all the changes discussed in v2, plus VDSO sframe support and
> Namhyung's perf tool patches (see detailed changelog below).
> 
> I did quite a bit of testing, it seems to work well.  It still needs
> some binutils and glibc patches which I'll send in a reply.
> 
> Questions for perf experts:
> 
>   - Is the perf_event lifetime managed correctly or do we need to do
>     something to ensure it exists in unwind_user_task_work()?
> 
>     Or alternatively is the original perf_event even needed in
>     unwind_user_task_work() or can a new one be created on demand?
> 
>   - Is --call-graph=sframe needed for consistency?
> 
>   - Should perf use the context cookie?  Note that because the callback
>     is usually only called once for multiple NMIs in the same entry
>     context, it's possible for the PERF_RECORD_CALLCHAIN_DEFERRED event
>     to arrive *before* some of the corresponding kernel events.  The
>     context cookie disambiguates the corner cases.
> 
> Based on tip/master.
> 
> Also at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git sframe-v3

Argh, apparently it's a bad idea to pass "*.patch" twice on the
git-send-email cmdline ;-)  Sorry for sending it twice!

-- 
Josh