Re: [PATCH v3 09/19] unwind: Introduce sframe user space unwinding

Josh Poimboeuf <[email protected]> Wed, 13 Nov 2024 13:13:30 -0800

Newsgroups	org.kernel.vger.linux-toolchains,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users
Message-ID	<20241113211330.hd6y32gfy4hbwqfm@jpoimboe>

On Wed, Nov 13, 2024 at 03:50:58PM -0500, Steven Rostedt wrote:
> On Wed, 13 Nov 2024 16:56:25 +0100
> Jens Remus <[email protected]> wrote:
> 
> > On 28.10.2024 22:47, Josh Poimboeuf wrote:
> > 
> > > diff --git a/kernel/unwind/user.c b/kernel/unwind/user.c  
> > 
> > > @@ -68,7 +83,12 @@ int unwind_user_start(struct unwind_user_state *state)
> > >   		return -EINVAL;
> > >   	}
> > >   
> > > -	state->type = UNWIND_USER_TYPE_FP;
> > > +	if (current_has_sframe())
> > > +		state->type = UNWIND_USER_TYPE_SFRAME;
> > > +	else if (IS_ENABLED(CONFIG_UNWIND_USER_FP))  
> > 
> > The test must be for CONFIG_HAVE_UNWIND_USER_FP. :-)
> 
> Yep, that too.

I also found this one, so that makes three of us!

It's too bad IS_ENABLED() doesn't catch typos.

-- 
Josh