Re: [PATCH v2 1/2] arm64: Implement arch_stack_walk_reliable
Josh Poimboeuf <[email protected]>
| Newsgroups | org.kernel.vger.linux-toolchains,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.live-patching |
|---|---|
| Message-ID | <yrqgoc66te54tuffkrc74clsosiid2giw3gpc3kd3ddl4662tb@kiqh3ncfxwnl> |
On Wed, Mar 19, 2025 at 02:37:06PM -0700, Song Liu wrote:
> +noinline noinstr int arch_stack_walk_reliable(stack_trace_consume_fn consume_entry,
> + void *cookie, struct task_struct *task)
> +{
> + struct kunwind_consume_entry_data data = {
> + .consume_entry = consume_entry,
> + .cookie = cookie,
> + };
> + int ret;
> +
> + ret = kunwind_stack_walk(arch_kunwind_consume_entry, &data, task, NULL, true);
> + if (ret == -ENOENT)
> + ret = 0;
Is this check redundant with the -ENOENT check in do_kunwind() which
already converts ret to zero?
--
Josh