Re: [PATCH 1/2] arm64: stacktrace: Check kretprobe_find_ret_addr() return value

Song Liu <[email protected]> Wed, 21 May 2025 09:35:58 -0700

Newsgroups	org.kernel.vger.linux-toolchains,org.infradead.lists.linux-arm-kernel,org.kernel.vger.live-patching
Message-ID	<CAPhsuW7C0Efu5PB8QKtOLM7yuE=NzNpZbnM_Yn56iTENj9gKHQ@mail.gmail.com>

On Wed, May 21, 2025 at 4:10 AM Mark Rutland <[email protected]> wrote:
>
> If kretprobe_find_ret_addr() fails to find the original return address,
> it returns 0. Check for this case so that a reliable stacktrace won't
> silently ignore it.
>
> Signed-off-by: Mark Rutland <[email protected]>
> Cc: Andrea della Porta <[email protected]>
> Cc: Breno Leitao <[email protected]>
> Cc: Catalin Marinas <[email protected]>
> Cc: Josh Poimboeuf <[email protected]>
> Cc: Miroslav Benes <[email protected]>
> Cc: Petr Mladek <[email protected]>
> Cc: Song Liu <[email protected]>
> Cc: Will Deacon <[email protected]>

Reviewed-and-tested-by: Song Liu <[email protected]>

Tested with livepatch changes [1][2] and modified kpatch
framework.

Thanks,
Song

[1] https://lore.kernel.org/live-patching/[email protected]/
[2] https://lore.kernel.org/linux-arm-kernel/[email protected]/