Re: [PATCH] libtracefs: Destroy synthetic and eprobes before other events

On 20/11/2024 3:57 am, Steven Rostedt wrote:
> On Fri, 18 Oct 2024 15:51:20 +0100
> Metin Kaya <[email protected]> wrote:
> 
>> I've these patches in my stash:
>>
>> * 8468f2e - (HEAD -> libtracefs) libtracefs utest: Add debug logs <Metin
>> Kaya>
>> * cee05c1 - libtracefs utest: Do not test more events than what the ring
>> buffer can hold <Steven Rostedt (Google)>
>> * 385650c - libtracefs utest: Fix min percent test <Steven Rostedt (Google)>
>> * c0810b9 - libtracefs utest: Add test to check handling multiple
>> dynamic events <Steven Rostedt (Google)>
>> * d8fcfff - libtracefs: Destroy synthetic and eprobes before other
>> events <Steven Rostedt (Google)>
>> * 78d8d2e - (origin/libtracefs, origin/HEAD) libtracefs: Have
>> tracefs_dynevent_get_all() find kprobes and uprobes properly <Steven
>> Rostedt (Google)>
> 
> I haven't applied this patch yet (but plan to). Is this still an issue
> for you?
> 
> -- Steve

I've some unit test failures (shown below) regardless of this patch. 
Tried to debug, but could not find the root cause.
This patch at least does not increase number of failures, but please 
ignore my setup for verifying it.

...
   Test: tracefs_iterate_snapshot_events API ...FAILED
     1. tracefs-utest.c:235  - ret == sizeof(struct test_sample)
     2. tracefs-utest.c:235  - ret == sizeof(struct test_sample)
     3. tracefs-utest.c:235  - ret == sizeof(struct test_sample)
   Test: tracefs_iterate_raw_events API ...FAILED
     1. tracefs-utest.c:235  - ret == sizeof(struct test_sample)
     2. tracefs-utest.c:235  - ret == sizeof(struct test_sample)
   Test: Follow events ...passed
   Test: Follow events clear ...passed
   Test: tracefs_tracers API ...passed
   Test: tracefs_local events API ...passed
   Test: tracefs_instances_walk API ...passed
   Test: tracefs_get_clock API ...passed
   Test: tracing on / off ...passed
   Test: tracing options ...passed
   Test: custom system directory ...passed
   Test: ftrace marker ...passed
   Test: kprobes ...passed
   Test: synthetic events ...passed
   Test: eprobes ...passed
   Test: uprobes ...FAILED
     1. tracefs-utest.c:2222  - ret == 0
     2. tracefs-utest.c:2222  - ret == 0

Run Summary:    Type    Total      Ran   Passed Failed Inactive
               suites        1        1      n/a      0        0
                tests       36       36       33      3        0
              asserts 26933635 26933635 26933628      7      n/a

Thanks,