Re: [PATCH 0/2] ccli: Two small fixes for ccli

On Thu, 21 Aug 2025 04:14:32 +0700
Ammar Faizi <[email protected]> wrote:

> Hi Steve,

Hi Ammar!

> 
> Alviro and I found two small issues in the ccli code.

There's a famous Linux kernel developer named Al Viro, and when I saw the
name Alviro, I was confused and was wondering why Al was working with you.
But then I saw the Cc list ;-)

> 
> The first one is a warning about uninitialized variable in the cache
> code. The second one is an optimization issue found when clang warns
> about unused return value of strlen() calls.
> 
> Fix them.
> 
> Ammar Faizi (2):
>   ccli: cache: Fix -Wuninitialized warning
>   ccli: commands: Fix optimized `strlen()` calls

Thanks for the updates!

FYI, I'm relicensing libccli under MIT from LGPL. Are you OK with that?

Cheers,

-- Steve


> 
>  src/cache.c      | 3 +--
>  src/ccli-local.h | 1 +
>  src/commands.c   | 1 +
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> 
> base-commit: 418ad6a341a5ab6c21be666565d62a878aa3bd18