Re: [PATCH] Print arrays like Linux does

On Mon, 20 Oct 2025 12:17:05 -0400
Sean Anderson <[email protected]> wrote:

> On 8/26/24 17:00, Sean Anderson wrote:
> > In Linux, trace_print_array_seq prints array elements as hexadecimal
> > numbers, separates them with commas, and surrounds the whole thing with
> > curly braces. Modify print_str_arg to use the same formatting.
> > 
> > Signed-off-by: Sean Anderson <[email protected]>
> > ---
> > 
> >  src/event-parse.c | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> > 
> > diff --git a/src/event-parse.c b/src/event-parse.c
> > index ba4a153..3c6f6f2 100644
> > --- a/src/event-parse.c
> > +++ b/src/event-parse.c
> > @@ -4938,18 +4938,19 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
> >  		len = eval_num_arg(data, size, event, arg->int_array.count);
> >  		el_size = eval_num_arg(data, size, event,
> >  				       arg->int_array.el_size);
> > +		trace_seq_putc(s, '{');
> >  		for (i = 0; i < len; i++) {
> >  			if (i)
> > -				trace_seq_putc(s, ' ');
> > +				trace_seq_putc(s, ',');
> >  
> >  			if (el_size == 1) {
> > -				trace_seq_printf(s, "%u", *(uint8_t *)num);
> > +				trace_seq_printf(s, "0x%x", *(uint8_t *)num);
> >  			} else if (el_size == 2) {
> > -				trace_seq_printf(s, "%u", *(uint16_t *)num);
> > +				trace_seq_printf(s, "0x%x", *(uint16_t *)num);
> >  			} else if (el_size == 4) {
> > -				trace_seq_printf(s, "%u", *(uint32_t *)num);
> > +				trace_seq_printf(s, "0x%x", *(uint32_t *)num);
> >  			} else if (el_size == 8) {
> > -				trace_seq_printf(s, "%"PRIu64, *(uint64_t *)num);
> > +				trace_seq_printf(s, "0x%"PRIx64, *(uint64_t *)num);
> >  			} else {
> >  				trace_seq_printf(s, "BAD SIZE:%d 0x%x",
> >  						 el_size, *(uint8_t *)num);
> > @@ -4958,6 +4959,7 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
> >  
> >  			num += el_size;
> >  		}
> > +		trace_seq_putc(s, '}');
> >  		break;
> >  	}
> >  	case TEP_PRINT_TYPE:  
> 
> ping

It's been accepted:

  https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/commit/?id=5f570de85c6b6a391c5e7ffea0b9a54fd8c4b043

I just haven't had time to make a new official release.

-- Steve