Re: [PATCH] trace-cmd report: add spacing before raw data flags

Hi!

Thanks for all the updates. I really do appreciate it. But some notes about
patches.

The subjects follow the Linux kernel tracing subsystem approach of starting
with a capital letter:

  trace-cmd report: Add spacing before raw data flags


On Mon,  6 Apr 2026 23:32:21 +0800
CaoRuichuang <[email protected]> wrote:

BTW, is CaoRuichuang your official name? As in one word. The DCO requires
real names, so I have to ask.

Also, even for small changes like this, please add content in the change
log body. The subject is about what is being done, but the change log body
is "why" it is being done. Here you explain "why" spacing is added before
raw data flags.

Thanks!

-- Steve


> Signed-off-by: CaoRuichuang <[email protected]>
> ---
>  tracecmd/trace-read.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tracecmd/trace-read.c b/tracecmd/trace-read.c
> index 355ee0f4..962ebd89 100644
> --- a/tracecmd/trace-read.c
> +++ b/tracecmd/trace-read.c
> @@ -871,7 +871,7 @@ void trace_show_data(struct tracecmd_input *handle, struct tep_record *record)
>  			TEP_PRINT_CPU);
>  
>  	if (raw_format)
> -		trace_seq_printf(&s, "-0x%x",
> +		trace_seq_printf(&s, " -0x%x",
>  				 tep_data_flags(pevent, record));
>  	else
>  		tep_print_event(pevent, &s, record,