Re: [PATCH v10 02/11] x86: hw_breakpoint: Add a kconfig to clarify when a breakpoint fires
Steven Rostedt <[email protected]> Thu, 23 Jul 2026 14:34:47 -0400
| Newsgroups | org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 23 Jul 2026 08:02:51 +0900 "Masami Hiramatsu (Google)" <[email protected]> wrote: > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index b58c2565024f..d9b6fa5c35d9 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -866,6 +866,7 @@ config WPROBE_EVENTS > bool "Enable wprobe-based dynamic events" > depends on TRACING > depends on HAVE_HW_BREAKPOINT > + depends on HAVE_POST_BREAKPOINT_HOOK > select PROBE_EVENTS > select DYNAMIC_EVENTS > help Is this really needed as a hard dependency? Is it just because you want to guarantee it happens after the breakpoint? What's wrong if it happens just before it changes? We should probably have a way to note it's before. But isn't it still useful to know *where* it was changed? -- Steve