Re: [PATCH v2 2/4] rv/reactors: propagate rv_register_reactor() error from reactor init

On Mon, 2026-08-03 at 02:43 +0800, [email protected] wrote:
> From: Wen Yang <[email protected]>
>=20
> Both register_react_printk() and register_react_panic() ignore the
> return value of rv_register_reactor() and always return 0.=C2=A0 If the
> registration fails (e.g. a duplicate reactor name), the init functions
> silently report success even though the reactor was not registered.
>=20
> Propagate the error from rv_register_reactor() so a failed registration
> is reported instead of being silently ignored.

Reviewed-by: Gabriele Monaco <[email protected]>

>=20
> Suggested-by: Gabriele Monaco <[email protected]>
> Signed-off-by: Wen Yang <[email protected]>
> ---
> =C2=A0kernel/trace/rv/reactor_panic.c=C2=A0 | 3 +--
> =C2=A0kernel/trace/rv/reactor_printk.c | 3 +--
> =C2=A02 files changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_pa=
nic.c
> index 76537b8a4343..db7116ceafff 100644
> --- a/kernel/trace/rv/reactor_panic.c
> +++ b/kernel/trace/rv/reactor_panic.c
> @@ -26,8 +26,7 @@ static struct rv_reactor rv_panic =3D {
> =C2=A0
> =C2=A0static int __init register_react_panic(void)
> =C2=A0{
> -=09rv_register_reactor(&rv_panic);
> -=09return 0;
> +=09return rv_register_reactor(&rv_panic);
> =C2=A0}
> =C2=A0
> =C2=A0static void __exit unregister_react_panic(void)
> diff --git a/kernel/trace/rv/reactor_printk.c
> b/kernel/trace/rv/reactor_printk.c
> index 48c934e315b3..002a10f6aa7b 100644
> --- a/kernel/trace/rv/reactor_printk.c
> +++ b/kernel/trace/rv/reactor_printk.c
> @@ -25,8 +25,7 @@ static struct rv_reactor rv_printk =3D {
> =C2=A0
> =C2=A0static int __init register_react_printk(void)
> =C2=A0{
> -=09rv_register_reactor(&rv_printk);
> -=09return 0;
> +=09return rv_register_reactor(&rv_printk);
> =C2=A0}
> =C2=A0
> =C2=A0static void __exit unregister_react_printk(void)