Re: [PATCH v1 03/11] KVM: arm64: nVHE: Declare the hyp event IDs before defining them

On Mon, Jul 20, 2026 at 05:13:35PM +0100, Fuad Tabba wrote:
> The defining expansion of HYP_EVENT() in events.c is the first time
> its translation unit meets hyp_event_id_<name>, so sparse suggests
> making the symbols static. Include kvm_hypevents.h ahead of
> define_events.h so the extern declarations come first, as with the
> tracepoint headers.
> 
> No functional change intended.
> 
> Signed-off-by: Fuad Tabba <[email protected]>

Reviewed-by: Vincent Donnefort <[email protected]>
Tested-by: Vincent Donnefort <[email protected]>

> ---
>  arch/arm64/kvm/hyp/nvhe/events.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/kvm/hyp/nvhe/events.c b/arch/arm64/kvm/hyp/nvhe/events.c
> index add9383aadb5a..b845be0acd117 100644
> --- a/arch/arm64/kvm/hyp/nvhe/events.c
> +++ b/arch/arm64/kvm/hyp/nvhe/events.c
> @@ -7,6 +7,8 @@
>  #include <nvhe/mm.h>
>  #include <nvhe/trace.h>
>  
> +#include <asm/kvm_hypevents.h>
> +
>  #include <nvhe/define_events.h>
>  
>  int __tracing_enable_event(unsigned short id, bool enable)
> -- 
> 2.39.5
> 

-- 
Vincent