Re: [PATCH] selftests/ftrace: allow relative paths in eprobe test
Martin Kaiser <[email protected]> Tue, 4 Aug 2026 21:51:01 +0200
| Newsgroups | org.kernel.vger.linux-trace-kernel,dev.linux.lists.oe-lkp,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest |
|---|---|
| Message-ID | <[email protected]> |
Thus wrote Masami Hiramatsu ([email protected]): > On Tue, 21 Jul 2026 22:05:59 +0200 > Martin Kaiser <[email protected]> wrote: > > The add/remove eprobe test installs an eprobe for the openat syscall, > > runs ls and checks the filenames that were opened. > > Commit 206b25c09080 ("tracing: eprobe: read the complete FILTER_PTR_STRING > > pointer") fixed access to some string fields in eprobes. This allows for > > dereferencing more filenames. In some cases, the log now shows a file > > with a relative path instead of "(fault)". A relative path makes the > > test fail. > > Relax the filename checks to fix the test. Allow shared libraries and > > locale configs that use a relative path. > Hmm, should we check this "nocontent" ? This change seems a bit fragile. > I think we should use another syscall to make sure getting filename > correctly. At least this point, removing nocontent check will be better. I've just sent another patch that uses chdir instead of openat. For chdir, we know which filename we'll see in the logs and we can use a simpler filter. Best regards, Martin