Re: [RFC PATCH bpf-next v2 1/2] ftrace: deprecate disabling via ftrace_enabled sysctl

Steven Rostedt <[email protected]> Wed, 5 Aug 2026 21:54:36 -0400

Newsgroups	org.kernel.vger.linux-trace-kernel,org.kernel.vger.bpf,org.kernel.vger.linux-doc,org.kernel.vger.linux-kselftest,org.kernel.vger.live-patching,org.kernel.vger.stable
Message-ID	<20260805215436.2a526204@robin>

On Fri, 31 Jul 2026 13:53:57 -0400
Andrey Grodzovsky <[email protected]> wrote:

>  
> -static void ftrace_shutdown_sysctl(void)
> +static void __maybe_unused ftrace_shutdown_sysctl(void)
>  {
>  	int command;
>  
> @@ -9377,7 +9377,7 @@ static void ftrace_shutdown_sysctl(void)
>  # define ftrace_shutdown_sysctl()      do { } while (0)
>  #endif /* CONFIG_DYNAMIC_FTRACE */
>  
> -static bool is_permanent_ops_registered(void)
> +static bool __maybe_unused is_permanent_ops_registered(void)
>  {
>  	struct ftrace_ops *op;

I agree with Sashiko: https://sashiko.dev/#/patchset/20260731175358.3542156-3-andrey.grodzovsky%40crowdstrike.com

Instead of marking with "__maybe_unused", just delete them. If we need
to revent, the revert will add them back.

-- Steve