Re: [PATCH v3 03/20] landlock: Split struct landlock_domain from struct landlock_ruleset

On Wed, Jul 22, 2026 at 05:12:18PM -0400, Justin Suess wrote:
> On Wed, Jul 22, 2026 at 07:11:35PM +0200, Mickaël Salaün wrote:
> > Switch all domain users to the new struct landlock_domain type
> > introduced by a previous commit, eliminating the conflation between
> > mutable rulesets and immutable domains. landlock_merge_ruleset() now
> > returns and allocates a struct landlock_domain, and the merge and
> > inherit helpers move next to it; the former static insert_rule() is
> > exported as landlock_rule_insert() for its new caller across the
> > translation-unit boundary.
> > 
> Seems a little confusing that we have
> 
> landlock_rule_insert()

(the new one)

> 
> and
> 
> landlock_insert_rule()

(the existing one)

> 
> Maybe a rename of one these would be appropriate?

It's indeed confusing...  What about landlock_store_rule()?  I couldn't
find anything better given the already taken names.

> 
> Otherwise looks good :)
> 
> Justin
> > [...]
>